search

CurationCorp / curation-corpus

Code for obtaining the Curation Corpus abstractive text summarisation dataset
Creative Commons Attribution 4.0 International
123 stars 27 forks source link

Define all imports in BART notebook #2

Closed awalther closed 4 years ago

awalther commented 4 years ago

Hi!

We are a group of volunteers working on organizing the scientific literature on coronavirus with NLP (https://www.coronawhy.org) and have come across your amazing repo. :) I've been going through the BART notebook and couldn't help but clearly define the imports in it, hence this PR. I know it's convenient to just dump everything into the namespace to explore but if you find this small change helpful, feel free to merge.

I've refactored the code in the BART notebook as a starting point for tuning towards science papers (ofc with proper acknowledgment), repo is here: https://github.com/awalther/scibart.

HenryDashwood commented 4 years ago

Thanks for this. Generally the fastai people have a different opinion when it comes to imports. I think I agree with you though. Don't forget load_learner though! I'll add that after merging