search

CuriousLearner / GeeksForGeeksScrapper

Scrapes g4g and creates PDF
MIT License
145 stars 68 forks source link

Links still points to geeksforgeeks in html and do not work in pdf #3

Open sahilshekhawat opened 8 years ago

sahilshekhawat commented 8 years ago

It will be helpful to navigate.

CuriousLearner commented 8 years ago

Yeah, links are not made to work locally right now. It's not a completely off-line version. If you want to work on it, please let me know here and issue a PR. I will gladly merge it.

Also, would like to know which links aren't working in PDF?

sahilshekhawat commented 8 years ago

Please refer to https://github.com/CuriousLearner/GeeksForGeeksScrapper/pull/4

PDF don't have any links.

CuriousLearner commented 8 years ago

Okay but since we're not storing categories/tags so these links won't work offline right?

So, how would this be useful. Also, links are working for PDFs.

CuriousLearner commented 8 years ago

Hello @sahilshekhawat, waiting for you reply on this :)