search

CuriousLearner / django-phone-verify

A Django app to support phone number verification using security code / One-Time-Password (OTP) sent via SMS.
https://www.sanyamkhurana.com/django-phone-verify/
GNU General Public License v3.0
258 stars 61 forks source link

fix(backends): Emit `post_save` signal on phone number verification #29

Closed arnav13081994 closed 4 years ago

arnav13081994 commented 4 years ago

Earlier the SMSVerification Model's queryset was being updated using update() which would not have allowed Django to emit its post_save signal when a new user's phone number gets verified successfully.

This is important for anyone listening for that event.

This small change will fix that issue.

CuriousLearner commented 4 years ago

Hi @arnav13081994

Is there a reason for closing this abruptly?

arnav13081994 commented 4 years ago

I was going to create a new PR. I actually don't know how to push my new commits to this commit so thought easiest would be to close this one and raise a new one that has everything.

CuriousLearner commented 4 years ago

You can work on the same PR. There is no need for additional PRs for the same task :)

arnav13081994 commented 4 years ago

Ok. I have committed my new changes.

arnav13081994 commented 4 years ago

I have pushed a new commit addressing everything. Please let me know if something needs to be improved.

CuriousLearner commented 4 years ago

Hey @arnav13081994

This is under the list of things I've to do. I'll be able to do this on Monday.

arnav13081994 commented 4 years ago

Ok thanks.

CuriousLearner commented 4 years ago

Hi @arnav13081994

There are a couple of things in the doc that would need to be enhanced. Do you mind if I work directly on it and push it to your branch?

arnav13081994 commented 4 years ago

Sure.

On Mon, 2 Dec 2019 at 11:09 PM, Sanyam Khurana notifications@github.com wrote:

Hi @arnav13081994 https://github.com/arnav13081994

There are a couple of things in the doc that would need to be enhanced. Do you mind if I work directly on it and push it to your branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CuriousLearner/django-phone-verify/pull/29?email_source=notifications&email_token=AE54TGOREW4XCI42427S2QTQWVB65A5CNFSM4JRVACC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFUI7TQ#issuecomment-560500686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE54TGLOENZCM22DVAPJNLLQWVB65ANCNFSM4JRVACCQ .

-- Regards,

Arnav