Remove decode() as its not needed for versions 3.8 +

CuriousLearner / django-phone-verify

A Django app to support phone number verification using security code / One-Time-Password (OTP) sent via SMS.

https://www.sanyamkhurana.com/django-phone-verify/

GNU General Public License v3.0

258 stars 61 forks source link

Remove decode() as its not needed for versions 3.8 + #53

Closed m7salam closed 3 years ago

m7salam commented 3 years ago

this should prevent the error of the str in decode we get if using version 3.8.5 or above

m7salam commented 3 years ago

CuriousLearner commented 3 years ago

Hi @m7salam 👋

Thank you for the PR.

The CI is failing https://travis-ci.com/github/CuriousLearner/django-phone-verify/builds/215598946#L351

Let me know once you fix it and I'll take a look at this and test the fix for various python versions.

Many thanks!

m7salam commented 3 years ago

@CuriousLearner its already ready and passed the checks :)

CuriousLearner commented 3 years ago

This had the fix commented out and is now superseded by #58

Thanks for your efforts @m7salam !

m7salam commented 3 years ago

@CuriousLearner the comment wasn't the solution it was the old one and I commented it when I solved it by following by updating a certain library you were using I found the updated version solved the problem so I made the update and pushed it and it succeeded all the tests

So the comments are useless it just needs to be removed and I'm sorry I didn't have time between work and got sick to remove it and push it

It's already passing all your tests and working well

CuriousLearner commented 3 years ago

Ok, no problem. I think everything will work from #58. I'm just waiting for CI to pass for each of the commits. Currently it seems like travis is having some issues and cancelling the builds mid-way.

So, I'm gonna fix those and release a new version.

Anyways, thanks for your time. I really appreciate it. :)