search

CuriousLearner / django-phone-verify

A Django app to support phone number verification using security code / One-Time-Password (OTP) sent via SMS.
https://www.sanyamkhurana.com/django-phone-verify/
GNU General Public License v3.0
258 stars 61 forks source link

fix(): Support for PyJWT v1.7.1 or later #57

Closed belal-bh closed 3 years ago

belal-bh commented 3 years ago

Hi @CuriousLearner

I was facing the same issue #51 I found that the main problem is the dependency package PyJWT version change. I have tried to fix this to support PyJWT v1.7.1 or later. It worked on python 3.8, 3.9. Could you please check the changes?

And thanks for the great package.

belal-bh commented 3 years ago

Thanks!

I'll work on the tox stuff and merge this when those changes are ready.

Thanks a lot. I want to learn more about it. Actually, I am very new to CI and testing. I have mistakenly closed the pull request! But I have reopened it. I've given the PyJWT issue and PR links the previous comment. Please check it.

And thanks a lot for helping me and contributing this great package!

CuriousLearner commented 3 years ago

I'm working on upgrades in this PR: https://github.com/CuriousLearner/django-phone-verify/pull/58

It is almost done. I'll test the comments that we added in this PR and then merge your changes in.

Many thanks!

CuriousLearner commented 3 years ago

I have added the changes to #58 and will merge it once the CI passes.

I'm closing this one.