search

CuriousScientist0 / ADS1256

An Arduino-compatible library for the ADS1256 24-bit analog-to-digital converter.
MIT License
31 stars 11 forks source link

issue with olimex esp32 poe and solution #1

Closed mafiou86 closed 9 months ago

mafiou86 commented 11 months ago

Dears, The module don't compile for olimex esp32 card due to an error of initialization values. The following modification in "ADS1256.cpp", line 44, solve the issue: before: ADS1256::ADS1256(const byte DRDY_pin, const byte RESET_pin, const byte SYNC_pin, const byte CS_pin, float VREF) after: ADS1256::ADS1256(const byte DRDYpin, const byte RESETpin, const byte SYNCpin, const byte CSpin, float VREF) : DRDY_pin(DRDYpin), RESET_pin(RESETpin), SYNC_pin(SYNCpin), CS_pin(CSpin) best regards

CuriousScientist0 commented 11 months ago

Thanks for your feedback! I will see if I can replace this code with your suggested line. I don't know if it would break the code for the 8 other microcontrollers that I already tested (with pass) the code with.

It might sound silly, but could you explain the difference between the two lines? I have never met the syntax you suggested, so I would like to learn more about it. Thanks!

CuriousScientist0 commented 9 months ago

This issue seems to be solved thanks to a kind contributor. Please check it!

https://github.com/CuriousScientist0/ADS1256/pull/7