search

CuriousScientist0 / ADS1256

An Arduino-compatible library for the ADS1256 24-bit analog-to-digital converter.
MIT License
31 stars 11 forks source link

Uno R4 and fix for some Compilers #7

Closed MaxMax-embedded closed 9 months ago

MaxMax-embedded commented 9 months ago

Hi, I checked your library example with an Arduino Uno R4 Wifi and after a small fix it works without any issues. The public const byte class members for the SPI etc. Pins cause a small compiler problem as in the Issue from mafiou86. The workaround with the initializer list works but I think the public class members are not really necessary because the lib works with the private members anyway after calling the constructor. Deleting them doesn't seem to change the functionality and removes the compiler errors. With this fixes the lib should work on almost all Arduino compatible boards.

CuriousScientist0 commented 9 months ago

Hi! Thank you for the contribution, this helps me a lot! I will test the code on my side, too after the merge. This must, as you mentioned, solve mafiou86's issue as well! Now I just have to fix the issues around the PGA and the unreliable register setting, and I will refresh the version in the Official Arduino Library Manager as well. Thanks once again!