search

CurrencyCloud / currencycloud-js

MIT License
20 stars 25 forks source link

Added the Cancel Conversion call #6

Closed eXeDK closed 6 years ago

eXeDK commented 6 years ago

This adds the call the canceling a conversion.

EAddario commented 6 years ago

Thanks for the contribution eXeDK. That particular API call is still in beta and has not yet been officially released, but once this is done and the documentation is updated accordingly we will review the pull request.

eXeDK commented 6 years ago

Hi Ed,

We are going use this call and instead of implementing the call and logic around it ourselves it made sense to add it to the package since we are already using the package. We asked internally in CC if this would be fine with you guys. That is why we made this PR.

Another question, are you guys interested in typings for this package?

EAddario commented 6 years ago

It was the right decision Thomas and we are specially grateful to all the people that have taken time to participate in our beta releases. I've reviewed the PR and looks solid. Assuming there are no changes on our side of the API (highly unlikely) we will close the beta and go general availability soon, at which point we will update our Development Centre site and go about the merge. For awareness, there may be one or two small changes we will request but let's cross that bridge when we get there.

As for the typings offer, Yes!!! but please hold back for a couple weeks before submitting. We're putting together a contributors.md file to help ease the process.

eXeDK commented 6 years ago

Fair enough. We'll put on our waiting hat for a bit.

I'll write the last of the typings and create a new PR for that later on.