search

CurrencyCloud / currencycloud-php

MIT License
15 stars 38 forks source link

Routing code value and type not aligned with the API #160

Open ghostika opened 10 months ago

ghostika commented 10 months ago

There is a problem with the implementation in the PHP SDK.

During beneficiary find method, if additional routing parameters are provided, the SDK generates the following field names:

routing_code_type_1 routing_code_value_1 routing_code_type_2 routing_code_value_2

Using the method, it generates this API error response: 

Invalid extra parameters:'{:routing_code_value_1=>"071922777", :routing_code_type_1=>"aba"}

The API expects an array of items: routing_code_type[0], routing_code_type[1]

ghostika commented 2 months ago

@jonathancouchman is there any chance that you will fix this or should we just fork your API and do the fix on our own for us? I see that another pull request has been open for 9 months now, where we also had to do a "native" API call...