search

CurricularAnalytics / CurricularAnalytics.jl

CurricularAnalytics.jl is a toolbox for studying and analyzing academic program curricula.
GNU Affero General Public License v3.0
23 stars 19 forks source link

Error in Calculated Delay Factor #85

Closed benhawk1 closed 4 years ago

benhawk1 commented 4 years ago

When creating degree plans, I noticed that several of the courses in the plan were displaying delay factors that appeared to be incorrect. Included in attachments are screenshots of the erroneous delay factors, as well as a word document containing code that can be used to replicate the display for errors 1 through 3.

Currently using CurricularAnalytics v0.6.6 and Julia v1.2.0, though this error was also occurring on CurricularAnalytics v0.6.3.

(Notes: Correct value for photo 1's delay factor is 7 (displayed as 4), photo 2's factor should be 7 (displayed as 5), photo 3 should be 8 (displayed as 6), photo 4 should be 6 (displayed as 5))

Please let me know if you need any more information regarding the bug, and thank you for your help!

Erroneous Delay Factor 1 Erroneous Delay Factor 2 Erroneous Delay Factor 3 Erroneous Delay Factor 4

ENME Curricular Analytics Code.docx

haydenfree commented 4 years ago

Ben,

Thanks so much for bringing this bug to our attention. There should be tests built in that check the metrics are being calculated correctly, but clearly at the least the visualization isn't showing the correct numbers. We will work to correct this as soon as possible.

heileman commented 4 years ago

Ben, can you send me the CSV files you used to create these programs? (greg.heileman@gmail.com) Thanks for reporting the bug. -Greg

benhawk1 commented 4 years ago

Sure thing! I'll send them now.

heileman commented 4 years ago

Fixed: delay_factor() was not finding all long paths, now it does. Screen Shot 2020-02-13 at 12 52 29 PM Screen Shot 2020-02-13 at 12 53 08 PM Screen Shot 2020-02-13 at 12 53 43 PM Screen Shot 2020-02-13 at 12 50 31 PM