CurryKitten / CurryKitten-Sim

FPV quad simulator
67 stars 7 forks source link

Quick Menu title rendering outside of viewport on iPhone XR #97

Closed CurryKitten closed 3 years ago

CurryKitten commented 3 years ago

Given that I developed the iOS version on an XR, I struggle to think how I missed this. Probably the fact that all the information is there, so it's only a simple title that's missing. What we see on the XR when in the quick menu is this

Screenshot 2021-07-17 at 00 16 32

When I check on this on the Unity editor, I can see that the title is rendering above the top of the screen limit

Screenshot 2021-07-17 at 00 16 39

This is only going to be a problem on the XR (and I think the iPhone 12 which has a similar aspect ratio) There are actually 2 issues here. Firstly, the overlay canvas doesn't use the canvas scaler script to alter the priority more onto the y axis in the case of such a widescreen, and secondly - even if it did, the UI container objects have incorrect anchors.

This is possibly the only UI element I didn't have to correct because it appeared to be correct, everything else had the canvas scaler and anchors corrected, so will do this same to this. As it happens I need to submit a whole new iOS build just to correct the tag line in the app store from "a fpv quadcopter" to "an fpv quadcopter"

CurryKitten commented 3 years ago

I fixed this without using a canvas scaler so that the text (and more importantly the buttons) will remain the same size. Hav uploaded this to the app store as 0.55.1 (because it won't let me have multiple builds against the same version).

Thinking about it, this may affect Android devices as well, but I just haven't found a device with the same aspect ratio. It'll go into the Android build on the next upload anyway.