search

CurryduckwithEC / CITS3403-agile-web-development

0 stars 0 forks source link

Accidentally worked on the main branch #21

Closed huangyegithub closed 5 months ago

huangyegithub commented 5 months ago

Hey guys, I accidentally worked on the main branch and modified user profile functionality, which was initially introduced by Aryton. There has been a lot of changes, including adding html pages, modification of css files, adding js files, major modification on py files. Could you test through the changes to make sure that everything works?

CurryduckwithEC commented 5 months ago

all right i will trying to make some test for the main branch

CurryduckwithEC commented 5 months ago

The issue lies within the login HTML page, where upon successful or unsuccessful registration, the red or green alert boxes are being obstructed by the page transition specified in the CSS. IMG_1209

CurryduckwithEC commented 5 months ago

https://github.com/CurryduckwithEC/CITS3403-agile-web-development/assets/151178276/9a0e649d-50ad-4850-814b-f5279a76b8c2

CurryduckwithEC commented 5 months ago

Test Success:

  1. During registration, flash message appears if the same username or user email is encountered.
  2. Edit user profile: Successfully edit all content. User email and password can be edited and then re-login.
  3. Edit user profile: When editing username, if it duplicates an existing username, editing is not allowed.(no error flash message
  4. Edit user profile: Change password: If the confirmation password doesn't match the previous one, it cannot be updated. (no error flash message

Failures:

  1. Screenshot 2024-05-18 at 3 25 49 PM When editing the profile, using an existing email returns an error.

huangyegithub commented 5 months ago

Looks good. Let me go inside and fix this.

huangyegithub commented 5 months ago

I think I have fixed this issue. The email address validity comparison was not properly addressed, so this error occurrs. I also fixed the issue with flash messages, where it was not properly shown on the webpage. I will submit a pull request for fixing these bugs. Please review the pull request and see how it works now.

huangyegithub commented 5 months ago

Hey guys, I would like to clarify that the current user profile code is built upon the foundation laid by Aryton. Sorry my initial description was inaccurate.