search

CurseForgeCommunity / .NET-APIClient

A CurseForge API Client (For CurseForge Core)
MIT License
12 stars 3 forks source link

Remove PartnerId and ContactEmail in ApiClient #3

Closed Misaka-L closed 1 year ago

Misaka-L commented 1 year ago

Remove PartnerId and ContactEmail in ApiClient because it's unnecessary.

itssimple commented 1 year ago

The reason I'm having PartnerId and ContactEmail, is so that it's easier for CurseForge to contact the person behind the API client, in case it starts abusing the API, or using it in a way that is not "good".

Misaka-L commented 1 year ago

The reason I'm having PartnerId and ContactEmail, is so that it's easier for CurseForge to contact the person behind the API client, in case it starts abusing the API, or using it in a way that is not "good".

I know now. But can we add a constructor that doesn't have these args?

itssimple commented 1 year ago

The reason I'm having PartnerId and ContactEmail, is so that it's easier for CurseForge to contact the person behind the API client, in case it starts abusing the API, or using it in a way that is not "good".

I know now. But can we add a constructor that doesn't have these args?

Yeah, I'll publish a version that doesn't require contactEmail, so there'll be 3 constructors.

itssimple commented 1 year ago

I added the new constructor and updated the API methods that had been updated. :) Closing this!