Update formatting - Githubissues

CurtRod / SimpleEVSE-WiFi

Brings EVSE WB/DIN into your WiFi

https://www.evse-wifi.de

78 stars 31 forks source link

Update formatting #30

Closed andig closed 4 years ago

andig commented 5 years ago

I was trying to understand the codebase and found I could improve readibility a bit. This PR adds the following changes:

cleanup indentation- always use 2 spaces and add .editorconfig
consistently format if/for opening/closing brackets
if functions exit early outdent following block
use ~~meterNode.ku8MBSuccess~~ != 0 for success check throughout
fix some minor typos
some obvious simplifications

Would appreciate feedback if this kind of PR is welcome ;)

If welcome I would be interested in making the following further changes:

intern all strings using F()
modularize code, e.g. move http and socket handling into separate files

Builds on #29

CurtRod commented 4 years ago

Sorry for the late reply. I've been too busy doing anything for EVSE-WiFi in the past few months. In the future, however, I would like to push the project forward again and develop new functions. I also thought about using PIO. Of course, your PR is welcome. I will check the changes soon and than merge the PR. Thank You!