Closed n15g closed 1 year ago
Im going to be busy this weekend but I will looks over this next week, thanks
I figured I would do a quick visual review of the code and yes... after telling it to ignore white space differences the changes are super minor.
I'll take your word that it works.
Although I don't really think it was necessary to add the line about the new embedding directory it doesn't really hurt to add it, so that's fine.
The line right after that adds the default embedding directory set by the program which should add the /model/embeddings
folder to the list of directories. I only hard coded /embeddings
as a fall back. But like I said it doesn't really hurt anything to also hard code the folder /models/embeddings
so you don't need to change it.
Thanks.
I just found a bug when using a non-standard directory, due to the filter() method returning an immutable list. (My weak Python skills kicking in). I'll raise a new PR to address that one.
The vladmandic port has the embeddings folder into the models folder, and has the LyCORIS extension built-in. The port has gained a ton of popularity recently, and the changes to make this extension work with it are relatively minor.
I've made the changes backward compatible, and confirmed they work with my Automatic1111 install.