CustomiesDevs / Customies

A PocketMine-MP plugin that implements support for custom blocks, items and entities.
MIT License
112 stars 53 forks source link

Rotatable trait doesnt work in version 1.3.0 #78

Closed LuciaDX closed 1 year ago

LuciaDX commented 1 year ago

Everything was working fine in 1.2.0 under pm4 but now these blocks dont rotate

xSuperr commented 1 year ago

+1 for 1.20 PM5

CoolCuzzy commented 1 year ago

Any solution found for this problem! Really urgent and it’s a really BIG problem.

TwistedAsylumMC commented 1 year ago

Could you try changing this line to use "states" rather than "properties"?

- ->setTag("properties", new ListTag(array_reverse($blockProperties))); // fix client-side order
+ ->setTag("states", new ListTag(array_reverse($blockProperties))); // fix client-side order

https://github.com/CustomiesDevs/Customies/blob/master/src/block/CustomiesBlockFactory.php#L130

royaljacques commented 1 year ago

i have looking this in the bedrock.dev : https://wiki.bedrock.dev/blocks/rotatable-blocks.html#facing-rotation-setup

"permutations": [
      {
        "condition": "query.block_property('wiki:rotation') == 0",
        "components": {
          "minecraft:transformation": { "rotation": [0, 0, 0] }
        }
      },
      {
        "condition": "query.block_property('wiki:rotation') == 1",
        "components": {
          "minecraft:transformation": { "rotation": [90, 0, 0] }
        }
      },
      {
        "condition": "query.block_property('wiki:rotation') == 2",
        "components": {
          "minecraft:transformation": { "rotation": [0, 0, 90] }
        }
      }
LuciaDX commented 1 year ago

Could you try changing this line to use "states" rather than "properties"?

- ->setTag("properties", new ListTag(array_reverse($blockProperties))); // fix client-side order
+ ->setTag("states", new ListTag(array_reverse($blockProperties))); // fix client-side order

https://github.com/CustomiesDevs/Customies/blob/master/src/block/CustomiesBlockFactory.php#L130

image This is the result

TwistedAsylumMC commented 1 year ago

This should be fixed by https://github.com/CustomiesDevs/Customies/pull/79, if anyone can test this it would be very appreciated

LuciaDX commented 1 year ago

This should be fixed by #79, if anyone can test this it would be very appreciated

Now every block that has trait just went invisible image

CoolCuzzy commented 1 year ago

Yeah issue not resolved.