search

CustomiesDevs / Customies

A PocketMine-MP plugin that implements support for custom blocks, items and entities.
MIT License
112 stars 52 forks source link

Block delay whilst placing #86

Open CoolCuzzy opened 1 year ago

CoolCuzzy commented 1 year ago

Hey! So essentially on my server were using our custom blocks for buildings etc

They seem to have a delay and aren’t as smooth as default blocks. Like for example if you attempt to jump and keep placing a block under you to stack up, you will fall to the side because of the delay, the block pushing you and you falling off.

Is there a resolution for this?

unickorn commented 1 year ago

To make sure this is related to Customies, could you make a vanilla world with an addon with custom blocks and test doing the exact same thing there?

CoolCuzzy commented 1 year ago

Tried it, theres no delay on the vanilla world.

IvanCraft623 commented 1 year ago

This issue is caused because this line: https://github.com/CustomiesDevs/Customies/blob/d783e62eb7a28c87c1932ef6bb3f20383c1a7e52/src/block/CustomiesBlockFactory.php#L123-L125

That component actually causes more problems than benefits, we could remove it and let each block decide whether to use it or not.

unickorn commented 1 year ago

@IvanCraft623 Could you provide an example of how that causes issues? Have you tested with/without that?