search

CustomiesDevs / Customies

A PocketMine-MP plugin that implements support for custom blocks, items and entities.
MIT License
107 stars 48 forks source link

Fix incorrect friction values being send in block components #94

Closed IvanCraft623 closed 11 months ago

IvanCraft623 commented 11 months ago

Close #93

dadodasyra commented 11 months ago

Seems to work

IvanCraft623 commented 11 months ago

LGTM, assuming this is tested. Are there any checks to prevent people from setting the friction factor to something outside the allowed range?

Block::getFrictionFactor() has @return float 0.0-1.0 in return type doc, so if it returns an incorrect value it will trigger phpstan