CuteOne / BadRotations

GNU General Public License v3.0
166 stars 213 forks source link

DK Blood -- attempt to cast.deathAndDecay using "playerGround" or "player" fails #1346

Closed BrewingCoder closed 7 months ago

BrewingCoder commented 7 months ago

trying to get death and decay to cast at the foot of the player, similar to the command "/cast [@player] Death and Decay"

using cast.deathAndDecay("player",nil,1,8) fails to cast and returns FALSE. this is already inside a target distance check of < 5 so we know at least 1 target is inside the AOE radius.

using the documented "playerGround" unit name the following error occurs:

414x [string "BadRotations/System/Functions/Custom.lua"]:103: attempt to perform arithmetic on a table value

[string "BrewBloodKnight.lua"]:253: in function run' [string "BadRotations/System/Loader/cCharacter.lua"]:222: in functionstartRotation' [string "BadRotations/System/Loader/cBuilder.lua"]:436: in function `update'

Locals: spellID = 43265 radius = 8 minUnits = 0 maxRange = 30 minRange = 0 spellType = "norm" unit = "player" = "Death and Decay" = nil = 136144 = 0 spellMinRange = 0 spellMaxRange = 30 allUnitsInRange = nil (temporary) =

{ 1 = "Creature-0-4224-1159-17660-87318-0000464C22" 2 = "Creature-0-4224-1159-17660-88314-0000464C22" } (temporary) =
{ } (temporary) = "player" (temporary) = 0 (temporary) = true (temporary) = false (temporary) = 236710742.918100 (temporary) =
{ Creature-0-4224-1159-17660-87318-0000464C22 =
{ } Creature-0-4224-1159-17660-88314-0000464C22 =
{ } } (temporary) =
{ } (temporary) = "Creature-0-4224-1159-17660-88314-0000464C22" (*temporary) = "attempt to perform arithmetic on a table value" br =
{ lastCastTable =
{ } storedTables =
{ } castGroundAtLocation = defined BadRotations/System/Engines/HealingEngineFunctions.lua:550 getFallDistance = defined BadRotations/System/Functions/Misc.lua:21 getRecharge = defined BadRotations/System/Functions/Spell.lua:182 canUseItem = defined BadRotations/System/Functions/Item.lua:11 getDebuffMinMax = defined BadRotations/System/Functions/Aura.lua:407 selectedProfile = 1 UnitAuraID = defined BadRotations/System/Functions/Aura.lua:29 getUnits = defined BadRotations/System/Functions/Custom.lua:72 healConeAround = defined BadRotations/System/Engines/HealingEngineFunctions.lua:360 debug =
{ } getTotemDistance = defined BadRotations/System/Functions/Range.lua:202 getHeirloomNeck = defined BadRotations/System/Lists/Items.lua:3 getOptionText = defined BadRotations/System/Functions/Misc.lua:838 canCast = defined BadRotations/System/Functions/Cast.lua:3 AuraData = defined BadRotations/System/Functions/Aura.lua:2 druid =
{ } getOptionValue = defined BadRotations/System/Functions/Misc.lua:835 fallDist = 0 getThreat = defined BadRotations/System/Functions/Custom.lua:347 castSpell = defined BadRotations/System/Functions/Cast.lua:227 canDisarm = defined BadRotations/System/Functions/Combat.lua:32 cancelBuff = defined BadRotations/System/Functions/Custom.lua:615 isHumanoid = defined BadRotations/System/Functions/Unit.lua:381 settingsDir = "\" data =
{ } getGlobalCD = defined BadRotations/System/Functions/Spell.lua:242 isMoving = defined BadRotations/System/Functions/Misc.lua:415 rotations =
{ } loader =
{ } lootManager =
{ } isLongTimeCCed = defined BadRotations/System/Functions/Misc.lua:394 hasBuff = defined BadRotations/System/Functions/Custom.lua:598 ComboMaxSpend = defined BadRotations/System/Loader/cBuilder.lua:634 castSpellMacro = defined BadRotations/System/Functions/Cast.lua:332 SpecificToggle = defined BadRotations/System/Functions/Misc.lua:597 getFallTime = defined BadRotations/System/Functions/Misc.lua:42 GetObjectPosition = defined BadRotations/System/Functions/Unit.lua:46 lists =
{ } engines =
{ } getGround = defined BadRotations/System/Functions/Misc.lua:242 spellDebug = defined BadRotations/System/Functions/Misc.lua:764 getNonExecuteEnemiesPercent = defined BadRotations/System/Engines/EnemiesEngineFunctions.lua:626 isNotBlacklisted = defined BadRotations/System/Functions/Custom.lua:84 devMode = defined BadRotations/System/Functions/Misc.lua:870 isUnitCasting = defined BadRotations/System/Functions/Cast.lua:564 getLowAllies = defined BadRotations/System/Functions/Combat.lua:84 PullTimerRemain = defined BadRotations/System/Functions/Custom.lua:870 getHealthPot = defined BadRotations/System/Functions/Item.lua:126 timeOfLastLoadingScreen = 236695.996000 castingUnit = <

CuteOne commented 7 months ago

I pushed an update that should solve the issue using "playerGround", is you want to use just "player" then I'd use it like this, cast.deathAndDecay("player","ground",1,8) so it will handle it properly.

BrewingCoder commented 7 months ago

78x [string "BadRotations/System/Functions/Custom.lua"]:74: attempt to get length of local 'allUnitsInRange' (a number value) [string "BadRotations/System/Functions/Custom.lua"]:74: in function `getUnits'

[string "BrewBloodKnight.lua"]:253: in function run' [string "BadRotations/System/Loader/cCharacter.lua"]:222: in functionstartRotation' [string "BadRotations/System/Loader/cBuilder.lua"]:436: in function `update'

Locals: thisUnit = "player" allUnitsInRange = 2 radius = 5 unitsAroundThisUnit =

{ } (temporary) = 1 (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to get length of local 'allUnitsInRange' (a number value)" br =
{ lastCastTable =
{ } storedTables =
{ } castGroundAtLocation = defined BadRotations/System/Engines/HealingEngineFunctions.lua:550 getFallDistance = defined BadRotations/System/Functions/Misc.lua:21 getRecharge = defined BadRotations/System/Functions/Spell.lua:182 canUseItem = defined BadRotations/System/Functions/Item.lua:11 getDebuffMinMax = defined BadRotations/System/Functions/Aura.lua:407 selectedProfile = 1 UnitAuraID = defined BadRotations/System/Functions/Aura.lua:29 getUnits = defined BadRotations/System/Functions/Custom.lua:72 healConeAround = defined BadRotations/System/Engines/HealingEngineFunctions.lua:360 debug =
{ } getTotemDistance = defined BadRotations/System/Functions/Range.lua:202 getHeirloomNeck = defined BadRotations/System/Lists/Items.lua:3 getOptionText = defined BadRotations/System/Functions/Misc.lua:838 canCast = defined BadRotations/System/Functions/Cast.lua:3 AuraData = defined BadRotations/System/Functions/Aura.lua:2 druid =
{ } getOptionValue = defined BadRotations/System/Functions/Misc.lua:835 fallDist = 0 getThreat = defined BadRotations/System/Functions/Custom.lua:435 castSpell = defined BadRotations/System/Functions/Cast.lua:227 canDisarm = defined BadRotations/System/Functions/Combat.lua:32 cancelBuff = defined BadRotations/System/Functions/Custom.lua:703 isHumanoid = defined BadRotations/System/Functions/Unit.lua:381 settingsDir = "\" data =
{ } getGlobalCD = defined BadRotations/System/Functions/Spell.lua:242 isMoving = defined BadRotations/System/Functions/Misc.lua:415 rotations =
{ } loader =
{ } lootManager =
{ } isLongTimeCCed = defined BadRotations/System/Functions/Misc.lua:394 hasBuff = defined BadRotations/System/Functions/Custom.lua:686 ComboMaxSpend = defined BadRotations/System/Loader/cBuilder.lua:634 castSpellMacro = defined BadRotations/System/Functions/Cast.lua:332 SpecificToggle = defined BadRotations/System/Functions/Misc.lua:597 getFallTime = defined BadRotations/System/Functions/Misc.lua:42 GetObjectPosition = defined BadRotations/System/Functions/Unit.lua:46 lists =
{ } engines =
{ } getGround = defined BadRotations/System/Functions/Misc.lua:242 spellDebug = defined BadRotations/System/Functions/Misc.lua:764 getNonExecuteEnemiesPercent = defined BadRotations/System/Engines/EnemiesEngineFunctions.lua:626 isNotBlacklisted = defined BadRotations/System/Functions/Custom.lua:84 devMode = defined BadRotations/System/Functions/Misc.lua:870 isUnitCasting = defined BadRotations/System/Functions/Cast.lua:564 getLowAllies = defined BadRotations/System/Functions/Combat.lua:84 PullTimerRemain = defined BadRotations/System/Functions/Custom.lua:958 getHealthPot = defined BadRotations/System/Functions/Item.lua:126 timeOfLastLoadingScreen = 240875.578000 castingUnit = defined BadRotations/System/Functions/Cast.lua:529 isActiveEssence = defined BadRotations/System/Functions/Spell.lua:329 checkBrOutOfDate = defined BadRotations/System/Unlockers.lua:31 textInterrupt = FontString { } canFly = defined BadRotations/System/Functions/Action.lua:2 getCharges = defined BadRotations/System/Functions/Spell.lua:161 isAggroed = defined BadRotations/System/Functi

CuteOne commented 7 months ago

Updated again, I see that it needs to be table return so I fixed it to properly remove the min range units from the max range units table instead of just the counts.