search

CuukyOfficial / VaroPlugin

Ein sehr funktionsreiches und performantes ODV & Varo Plugin mit API u.v.m.
https://docs.varoplugin.de
GNU Affero General Public License v3.0
17 stars 21 forks source link

Customizable text when no topkiller/team exists #70

Closed xNoobyyy closed 2 years ago

xNoobyyy commented 2 years ago

Added Option to pause countdown of player + pause when /freeze (KEINE AHNUNG WIE MAN ZWEI PULL REQUESTS MACHT DAS HAT DAS AUTOMATISCH HINZUGEFÜGT AAAHHHH)

Almighty-Satan commented 2 years ago

The first commit looks good (except for the requested changes) and can be merged into v4. But I'm not a fan of merging the second commit into v4 because the way you implemented it, pausing the countdown does not work during mass-recording. That's not your fault tho as the mass-recording feature is just extremely poorly implemented in general and I already know that modifying a players countdown during mass-recording will cause issues. We are going to rewrite the mass-recording feature in v5. Therefore I would suggest moving the second commit to a different branch and rebasing it on dev-v5 once v5 is ready to accept pull requests. Also the "pause" and "unpause" commands share A LOT of very similar code that could be moved to a common superclass and the messages should be made customizable.

PS: PRs should always target a dev branch unless its a simple bug fix

xNoobyyy commented 2 years ago

See Second PR