Resolved MainSaveFile Singleton anti-pattern and added Turnip prices

Cuyler36 / MyHorizons

WIP Animal Crossing: New Horizons Save Editor

GNU General Public License v3.0

135 stars 33 forks source link

Resolved MainSaveFile Singleton anti-pattern and added Turnip prices #24

Closed igromanru closed 4 years ago

igromanru commented 4 years ago

Hi, I added Turnip prices to MyHorizons.
While I was working with the code I couldn't overlook the MainSaveFile.Singleton(). It isn't a real Singletone and it can be solved without it, I hope you don't mind my refactoring.

Cuyler36 commented 4 years ago

Also I'm not a fan of the name "Turnips". Preferably the name should convey purpose. You aren't editing the turnips but rather the selling/buy price. I'd prefer something more like "StalkMarket".

igromanru commented 4 years ago

Funny thing, I was also thinking about it, after I created the PR.
How do you like it now?