CuzIm1Tigaaa / Spectator

This Plugin allows you to easily spectate players without needing permissions for /gamemode!
10 stars 2 forks source link

[Feature Request/Bug] Air Bubbles Restore in Spec #10

Closed RillSoji closed 1 year ago

RillSoji commented 1 year ago

Currently the plugin allows the player to regain all air bubbles if they move out of the water while in spectate. Would like to see a fix or config option to retain the status of the player's air when switching in/out of spec. Thank you!

Geckomacabre commented 1 year ago

Tiga if you can try to contact RealBaconEater or https://github.com/cunhar for help developing this plugin. He has a Youtube called Hoobs Live that utilizes a plugin very similar to this.🙏

CuzIm1Tigaaa commented 1 year ago

Currently the plugin allows the player to regain all air bubbles if they move out of the water while in spectate. Would like to see a fix or config option to retain the status of the player's air when switching in/out of spec. Thank you!

Sorry for the late response. I think the air should get restored even if the player does not leave the water in spectator mode, right? But yes, of course I can add a config value for this.

EDIT: I don't think you actually need a config value for this lol

RillSoji commented 1 year ago

No worries! It's just a semi-cheaty way to avoid drowning lol

CuzIm1Tigaaa commented 1 year ago

Yeah I know 😅 same with burning to death bc you stop burning after switching to spectator mode haha

CuzIm1Tigaaa commented 1 year ago

The remaing air and the fire ticks are now saved when going in spectator mode. This is configurable under "PlayerData", default is set to true. If true, both the remaing air and the duration a player is burning are applied when leaving spectator mode