Closed benoitf closed 7 months ago
@benoitf Yes, please feel free to submit a PR!
@benoitf are you working on it?
hello, I forgot I'm not working on it right now
@Cweili Example of another package that had to make similar changes: https://github.com/fedorovvvv/svelte-floating-ui/commit/a1f7bee81ed60a2dcbe143dfc4b0cefd48cde22a
hello,
first, I'm happy to use this library.
But recently I faced an issue with
vite-plugin-svelte
andvite5
When this library was made, these components were older :-)Here is the issue: https://github.com/sveltejs/vite-plugin-svelte/issues/813
it seems svelte-fa is not following new recommended approach for svelte usage.
Running it now I can see
and here is the recommandation provided in the vite plugin svelte issue
I don't know if you would accept such PR ?