CxJasonT / CxFlowBodgeit

CxOne PR and CxFlow webhook
0 stars 0 forks source link

CX SQL_Injection @ root/basket.jsp [master] #15

Open CxJasonT opened 3 years ago

CxJasonT commented 3 years ago

SQL_Injection issue exists @ root/basket.jsp in branch master

The application's stmt.execute method executes an SQL query with execute, at line 274 of root\basket.jsp. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly. An attacker would be able to inject arbitrary syntax and data into the SQL query, by crafting a malicious payload and providing it via the input getCookies; this input is then read by the request.getCookies method at line 38 of root\basket.jsp. This input then flows through the code, into a query and to the database server - without sanitization. This may enable an SQL Injection attack.

Severity: High

CWE:89

Checkmarx

Training Recommended Fix

Lines: 148 212 38 43


Code (Line #148):

    String productId = request.getParameter("productid");

Code (Line #212):

        Map params = request.getParameterMap();

Code (Line #38):

    Cookie[] cookies = request.getCookies();

Code (Line #43):

                basketId = cookie.getValue();

CxJasonT commented 3 years ago

Issue still exists.

CxJasonT commented 3 years ago

Issue still exists.