search

Cxbx-Reloaded / Cxbx-Reloaded

Xbox (Original) Emulator
https://cxbx-reloaded.co.uk
GNU General Public License v2.0
2.2k stars 257 forks source link

Verify X_D3DPT_QUADLIST StartVertex > 0 in DrawVertices #1156

Open PatrickvL opened 6 years ago

PatrickvL commented 6 years ago

In EmuPatch_D3DDevice_DrawVertices, a test case popup was added for "X_D3DPT_QUADLIST StartVertex > 0".

Verify if this case is handled correctly. If not, document the problem here and try to fix it. Once deemed correct, disable the popup.

Test cases:

JohnGodgames commented 6 years ago

Flight Academy

---------------------------
Cxbx-Reloaded
---------------------------
Please report that FlightAcademy shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7519)
---------------------------
OK   
---------------------------

GENMA ONIMUSHA

---------------------------
Cxbx-Reloaded
---------------------------
Please report that GENMA ONIMUSHA shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7519)
---------------------------
OK   
---------------------------

Heroes of the Pacific

---------------------------
Cxbx-Reloaded
---------------------------
Please report that Heroes of the Pacific shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7519)
---------------------------
OK   
---------------------------

Hummer Badlands

---------------------------
Cxbx-Reloaded
---------------------------
Please report that Hummer shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7519)
---------------------------
OK   
---------------------------

Knights Of The_Temple 2

---------------------------
Cxbx-Reloaded
---------------------------
Please report that KOTT2 shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7519)
---------------------------
OK   
---------------------------

LakeMasters Bass fishing

---------------------------
Cxbx-Reloaded
---------------------------
Please report that LAKEMASTERS shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7519)
---------------------------
OK   
---------------------------
kennethedmonds commented 6 years ago

SpiderMan 2

---------------------------
Cxbx-Reloaded
---------------------------
Please report that SpiderMan 2 shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7521)
---------------------------
OK   
---------------------------
kennethedmonds commented 6 years ago

All-Star Baseball '03

---------------------------
Cxbx-Reloaded
---------------------------
Please report that All-Star Baseball '03 shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7521)
---------------------------
OK   
---------------------------

BLiNX: the time sweeper

---------------------------
Cxbx-Reloaded
---------------------------
Please report that BLiNX: the time sweeper shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7521)
---------------------------
OK   
---------------------------

Night Caster 2

---------------------------
Cxbx-Reloaded
---------------------------
Please report that NightCaster2 shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7521)
---------------------------
OK   
---------------------------

Pinball Hall of Fame

---------------------------
Cxbx-Reloaded
---------------------------
Please report that Pinball Hall of Fame shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7521)
---------------------------
OK   
---------------------------

Stubbs the Zombie

---------------------------
Cxbx-Reloaded
---------------------------
Please report that Stubbs the Zombie shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7521)
---------------------------
OK   
---------------------------
haradons commented 6 years ago

Halo: Combat Evolved image

jagotu commented 6 years ago

Harry Potter and the Sorcerer's Stone

---------------------------
Cxbx-Reloaded
---------------------------
Please report that Harry Potter and the Sorcerer's Stone shows this test-case: X_D3DPT_QUADLIST StartVertex > 0
In EmuPatch_D3DDevice_DrawVertices (c:\work\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 7554)
---------------------------
OK
---------------------------
gandalfthewhite19890404 commented 6 years ago

Add this - FIFA World Cup 2002 https://github.com/Cxbx-Reloaded/game-compatibility/issues/568

blueshogun96 commented 6 years ago

Don't forget Robotech: Battlecry, it used quadratic rendering rather extensively. Minus a few buggy particle effects, the game looks and sounds great.

Shogun

imivz commented 6 years ago

BLiNX: the time sweeper udklip

RadWolfie commented 5 years ago
PatrickvL commented 5 years ago

Work on this has been done in merged PR #1757 However, the test cases listed in this issue must still be verified and documented per test case (here, in this issue), so that we have a clear and actual overview of how this scenario is now handled (correctly or not). If everything seems to work correct, we can close this issue. If not, this issue must be updated with a status per test case, and the remaining work just be clearly described.

ObiKKa commented 4 years ago

You forgot to add Genma Onimusha from the first reply from JGG to the OP's list. Please put it there.

An ancient test report that went unnoticed.

Aug 2019:

Midtown Madness 3, in a test by an user on November 30, 2020, revealed 8 different popup messages, including the one for this issue.

Metal Dungeon, in a test by an user on October 18, 2020, revealed 9 different popup messages, including the one for this issue.

There are a total of three popup messages related to the use of "X_D3DPT_QUADLIST". The two others of those are:

I think it would be better for a coder to cover all of these popups in one PR if that's possible and clear these tasks up.

Title: