Cxbx-Reloaded / XbSymbolDatabase

Xbox Symbol Database library
MIT License
23 stars 10 forks source link

D3DDevice_LoadVertexShader_0 (LTCG) wrong order parameters #191

Open RadWolfie opened 1 year ago

RadWolfie commented 1 year ago

Even though parameters' names are matching with registers but the order is incorrect for the actual parameter.

D3DDevice_LoadVertexShader(dword_xt Handle, dword_xt Address);

The following function above demonstrate Handle is first parameter and Address is second parameter. However, both CxbxR and this repositories are currently set to:

D3DDevice_LoadVertexShader_0__LTCG_eax_Address_ecx_Handle
D3DDevice_LoadVertexShader_0__LTCG_eax_Address_edx_Handle

when it should had been:

D3DDevice_LoadVertexShader_0__LTCG_ecx_Handle_eax_Address
D3DDevice_LoadVertexShader_0__LTCG_edx_Handle_eax_Address

Since we are currently moving away from named parameter onto register. It will be change to:

D3DDevice_LoadVertexShader_0__LTCG_ecx1_eax2
D3DDevice_LoadVertexShader_0__LTCG_edx1_eax2