Cxbx-Reloaded / XbSymbolDatabase

Xbox Symbol Database library
MIT License
24 stars 10 forks source link

Yetisports is probably missing a SetRenderTarget patch #29

Closed PatrickvL closed 1 year ago

PatrickvL commented 6 years ago

image

It's a 5849 title, and it has this in the log :

HLECache: 0x00439470 -> D3DDevice_SetRenderTarget   *PATCHED*
HLECache: 0x004396f0 -> D3DDevice_SetRenderTargetFast   *PATCHED*

but the white square in the top-left corner seems to indicate it isn't patched correctly...

PatrickvL commented 6 years ago

Hm, D3DDevice_SetRenderTargetFast actually forwards the call to D3DDevice_SetRenderTarget, but that function calls into the Xbox version of D3DDevice_SetRenderTarget via a trampoline, so the behavior of Xbox D3DDevice_SetRenderTargetFast is different from what would happen normally.

On the other hand, a breakpoint placed in our D3DDevice_SetRenderTargetFast patch never gets hit, so it's not the cause of the strange behaviour...

RadWolfie commented 6 years ago

Is Yetisports a LTCG title?

EDIT: If possible make a reference link to an existing issue with this title. If there is none, that's okay.

PatrickvL commented 6 years ago

There's none

RadWolfie commented 1 year ago

Symbol detection is accurate and title is visible in Cxbx-Reloaded emulation. Likely due to further improvement in past years. Closing as not an issue.