search

Cxbx-Reloaded / game-compatibility

Cxbx-Reloaded game compatibilty list, using GitHub issues
GNU General Public License v2.0
115 stars 29 forks source link

Robotech Battlecry [TM-002] [1.01] #168

Open PatrickvL opened 6 years ago

PatrickvL commented 6 years ago

Wikipedia

From @furrya on March 25, 2017 23:37

Robotech Battlecry goes ingame with some broken graphics and missed intros and some videos screenshot_9 screenshot_10 screenshot_11 screenshot_12 screenshot_13 Xbe.txt Sorry, i have not able to attach KrnlDebug.txt beacause it reaches about 221 mb

Copied from original issue: Cxbx-Reloaded/Cxbx-Reloaded#277

PatrickvL commented 6 years ago

From @blueshogun96 on April 8, 2017 23:36

Okay, the reason this happens is because there is a bug in Cxbx's vertex data patching code somewhere. Revel8n and I worked together on this with Cxbx years ago and we came up with a fix to skip the rendering of the skydome. If you can make it to level 3, this issue does not come up.

For a specific explanation here, consider the code in D3DDevice_DrawIndexedVertices and look at the Vertex patching code (see https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/blob/master/src/CxbxKrnl/EmuD3D8.cpp#L7911). There's a bug where this code fails and causes the emulator to crash when the data is sent through the pipeline. I forgot exactly what we were thinking at the time, but I wrote a quick workaround to avoid the crash as there was no valid vertex buffer data to patch. There's likely a much better way to fix this, I just didn't think of anything else at the time. Because of Cxbx's design, it was kinda hard for me to debug it.

Hopefully that sheds some light on the issue.

Shogun

blueshogun96 commented 6 years ago

Okay, the gfx were broken even further now. Revel8n had fixed this issue with broken geometry years before (and I forgot exactly what he did; and it was a simple fix) and someone likely removed it between now and August. I wouldn't be surprised if it was causing broken gfx in several other games.

Shogun

ObiKKa commented 6 years ago

I think this video from JGG rhymes with what blueshogun said about the geometry problem. There are heavily corrupted render-draw problems in both the menus' background (But you can see the overlays & text) and gameplay view (Only a couple GUI icons are visible).

Edit (17/03/2018): JGG had uploaded two newer videos on this game. But I'm only adding the latest one. It shows much better improvements in the rendering of the menus' backgrounds (Look great) and in-game GFX (Still has some small render-draw problems). The shading on various 3D models, including the mecha in the menu view window and others in the gameplay are slightly glitched out (Multiple colours).

Edit (Dec 13, 2020):

(This PR # 2048 (Optimize vertex stream cache for partial buffer access), dated November 27, 2020, was tested to help with this game's performance. It should now run much faster than 60 FPS without framecap.

Also see this performance improvements roundup video from Literalmente{Game} (Aka Strelok on Discord & Luke Usher's Patreon reports):