search

Cxbx-Reloaded / xbox_kernel_test_suite

Xbox kernel APIs tester written using nxdk
GNU General Public License v3.0
22 stars 6 forks source link

Use new wchar xlibc function in nxdk for the RtlAppendUnicodeStringToString test #48

Closed Fisherman166 closed 5 years ago

Fisherman166 commented 5 years ago

After this pull request to nxdk is merged, this pull request can be merged: https://github.com/XboxDev/nxdk/pull/79

I updated the first unicode string test function to 1. Use the new wchar xlibc functions in nxdk to cleanup p the code and 2. Actually compare the result buffer to an expected unicode string. This greatly improves testing ability as before I was just checking if the pointer of the buffer matched itself.

PatrickvL commented 5 years ago

May it be assumed this now awaits the merging of https://github.com/XboxDev/nxdk/pull/82 ?

Fisherman166 commented 5 years ago

Yes that would be the safer bet as that will hopefully be the long-term solution.

PatrickvL commented 5 years ago

Status : still awaiting merge of remote PR

PatrickvL commented 5 years ago

Still awaiting the merge of the reference pr

Fisherman166 commented 5 years ago

This can finally be merged as my PR was accepted: https://github.com/XboxDev/nxdk/pull/82

PatrickvL commented 5 years ago

Status : The remote PR mentioned above is now merged, however, Travis CI now fails building this - once that is addressed, this PR can (finally!) be reviewed & merged.

Fisherman166 commented 5 years ago

It just needed a rebuild with the new code from nxdk. All passing now.