search

Cxbx-Reloaded / xbox_kernel_test_suite

Xbox kernel APIs tester written using nxdk
GNU General Public License v3.0
22 stars 6 forks source link

Fix issue #56 and #45 (TEST BEFORE MERGE) #58

Closed Luca1991 closed 5 years ago

Luca1991 commented 5 years ago

Hi all, due to the recent addition of PDClib in nxdk, we weren't able to build xkts due to a missing function. A public domain implementation of this missing function (strtok_r) is now part of xkts. This fix issue #56 . Minor: I also added the Travis CI link to the README, fixing issue #45 .

Now, read carefully: 1) I tested xkts on my real xbox (screenshot: https://i.postimg.cc/Y9HpcH9k/photo-2019-04-26-14-45-39.jpg) and it works, but I was not able to test it using CxBx-R (I can't remember how we used to get the output log...). 2) I found a regression in XCreateFile: it the file already exist, it will NOT overwrite it.

Thank you, Luca

LukeUsher commented 5 years ago

@Luca1991 now that nxdk has a real libc (PDClib) you shouldn't need to use the XCreateFile API anymore. You should be free to use the standard fopen, fread, fwrite, etc family of functions.

JayFoxRox commented 5 years ago

Reminder @Cxbx-Reloaded and @Luca1991

I found a regression in XCreateFile: it the file already exist, it will now overwrite it.

This change isn't part of this PR? I also don't remember an upstream PR? So why is this mentioned / how was it solved?

Luca1991 commented 5 years ago

Reminder @Cxbx-Reloaded and @Luca1991

I found a regression in XCreateFile: it the file already exist, it will NOT overwrite it.

This change isn't part of this PR? I also don't remember an upstream PR? So why is this mentioned / how was it solved?

Hi Jay, no this isn't part of this PR. This is just something I noticed when testing this PR in my real xbox. Also there was a typo in my origianal post, I've written "now" istread of "not". Anyway when I'll have some free time, I'll replace XCreateFile with a standard API as suggested by Luke.

ergo720 commented 5 years ago

I tested this with cxbxr https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/commit/1314496cb3d4db0798b11da4a4850c2b668adfa0 and I can confirm that it works fine (but only when building with -DNDEBUG, to workaround another unrelated problem), so this can be merged.

Luca1991 commented 5 years ago

Just want to let @JayFoxRox know that I opened an issue upstream (pdclib) about the private strtok_r. You can find it here: https://github.com/DevSolar/pdclib/issues/4