search

Cxbx-Reloaded / xbox_kernel_test_suite

Xbox kernel APIs tester written using nxdk
GNU General Public License v3.0
22 stars 6 forks source link

video: Add XVideoSetMode() #59

Closed dracc closed 5 years ago

dracc commented 5 years ago

XboxDev/nxdk-pdclib#3 will require XVideoSetMode() to be ran per application.

Luca1991 commented 5 years ago

Ok, but this should be merged AFTER #58

PatrickvL commented 5 years ago

Could someone fix this?

[ LD       ] main.exe
lld: warning: /home/travis/build/cxbx-reloaded/nxdk/projects/xbox_kernel_test_suite/main.obj: undefined symbol: _strtok_r
error: link failed
make: *** [main.exe] Error 1
The command "make" exited with 2.
Done. Your build exited with 1.
dracc commented 5 years ago

@PatrickvL Fixed! :+1:

Luca1991 commented 5 years ago

@ergo720 I'm not sure that was a good idea to merge this! The upstream commit (https://github.com/XboxDev/nxdk-pdclib/pull/3) is not yet merged.

EDIT: as Jay pointed out,

the existing mode will be set twice (in quick succession)

this shouldn't cause problems, but it wasn't tested as far as I know.

ergo720 commented 5 years ago

I tested it with https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/commit/1314496cb3d4db0798b11da4a4850c2b668adfa0 and with the workaround mentioned in https://github.com/Cxbx-Reloaded/xbox_kernel_test_suite/issues/60: it works fine for me (I should probably have mentioned it though).