search

Cxbx-Reloaded / xbox_kernel_test_suite

Xbox kernel APIs tester written using nxdk
GNU General Public License v3.0
22 stars 6 forks source link

Add Output Video Option #94

Closed RadWolfie closed 7 months ago

RadWolfie commented 7 months ago

I got annoyed by no space in statements. So I made the fix format commit first.

Since open log file and read config file needs to be done first. Any print calls to screen are require to be disable first until read from config file. Then make the output video default to true if disable-video key was not given or set to respective value.

I'm currently mark this pull request as draft to verify team's approval to move forward with. Otherwise, I could make video output to always false which will require contributors/testers to use config file.

In config.txt file: disable-video=<boolean, 1 or 0 number only>

ergo720 commented 7 months ago

Nit: the format commit should probably have been submitted in a separate PR, since it's not part of the video output option being added here

RadWolfie commented 7 months ago

Nit: the format commit should probably have been submitted in a separate PR, since it's not part of the video output option being added here

Yes, it could had been in a separate pull request. Although, it is only one file, main.c, had to be fixed for format in order to accept new changes from this pull request without conflict.