Cxbx-Reloaded / xbox_kernel_test_suite

Xbox kernel APIs tester written using nxdk
GNU General Public License v3.0
22 stars 6 forks source link

HOTFIX: Fix line reader to support file saved from all platforms #97

Closed RadWolfie closed 9 months ago

RadWolfie commented 9 months ago

I had some sort of issue with the submitter field from #95 pull request. And when I started to work on adding the name option field. It wasn't able to create the custom log file. Which led me back to the submitter field issue I had. I didn't check the log file in Notepad++ which exposed \r character leaked in the submitter field output. I recently realized strtok calls actually need "\r\n" instead of "\n" to work with all platforms' files to read from.

RadWolfie commented 9 months ago

Perhaps it's useful to add a comment that explains why both characters are required...

Added comment to explained the reason.

PatrickvL commented 9 months ago

Splendid!