CyBear-Jinni / cbj_hub

🕸️ Easy to use open source Hub to control your smart devices from one app.
https://cybearjinni.com
GNU Affero General Public License v3.0
31 stars 21 forks source link

Make a professional diagram out of an existing one #19

Closed guyluz11 closed 6 months ago

guyluz11 commented 2 years ago

The concept of how the code of the Hub is being divided is not so clear at first glance.

I created the diagram but it should be remarked to look more professional.

CBJ Hub diagram

Mitternachtsmond commented 1 year ago

@guyluz11 Can I do this issue under the hacktoberfest?

guyluz11 commented 1 year ago

I am not sure how to commit to Wiki works

@guyluz11 Can I do this issue under the hacktoberfest?

The current diagram is located here https://github.com/CyBear-Jinni/cbj_hub/wiki/Coding-guidelines

I am not sure how can it count for you as I am not sure if commits to Wiki can go through pr request.

Maybe from here? https://github.com/CyBear-Jinni/cbj_hub.wiki.git

Mitternachtsmond commented 1 year ago

Page does not exist @guyluz11

guyluz11 commented 1 year ago

https://github.com/CyBear-Jinni/cbj_hub.wiki.git

Screenshot_20221005-012439_Firefox

This is what I get for copying the bottom url

Mitternachtsmond commented 1 year ago

I will make a diagram and if it's accepted by you @guyluz11 You can add hacktoberfest-accepted label if you approve it

guyluz11 commented 1 year ago

I can add hacktoberfest-accepted lable to this issue.

Is that what you meant?

Mitternachtsmond commented 1 year ago

If the diagram I make is accepted by you then you can add the hacktoberfest-accepted label to the PR

guyluz11 commented 1 year ago

Ok

Mitternachtsmond commented 1 year ago

Can you assign me this issue @guyluz11 I have started on this issue

guyluz11 commented 1 year ago

Hi @Mitternachtsmond I am removing you from Assignees but your pr will still be merged if it will be accepted

Thanks

guyluz11 commented 6 months ago

Most of the Hub functionality had moved to cbj_integrations_controller to allow use in the Hub and the App. So the architecture moved as well, here is a link to it https://github.com/CyBear-Jinni/cbj_integrations_controller/wiki