CyCoreSystems / ari

Golang Asterisk REST Interface (ARI) library
Apache License 2.0
189 stars 73 forks source link

Protobuf defnitions for *Request structs #124

Open blaggacao opened 3 years ago

blaggacao commented 3 years ago

I want to build the following protobuf:

syntax = "proto3";

package vicigo.dialer.commands;

option go_package = "commands";

import "google/protobuf/timestamp.proto";
import "github.com/CyCoreSystems/ari/ari.proto"; // here, I'd like to have all request structs available.

message Originate {
  asterisk.ari.OriginateRequest req = 1; // here is how I would like to use it.

  string agent_load_balance_strategy = 2;
  ...
}

Would that be possible / a PR accepted?

Ulexus commented 2 years ago

Makes sense. I've started several times converting all the basic structs to protobuf, but I never end up liking it. The code generator just needs to be extended to do this.

PRs welcome. :)