search

CyCoreSystems / ari

Golang Asterisk REST Interface (ARI) library
Apache License 2.0
191 stars 73 forks source link

Fix query parameters of externalMedia #133

Closed hwiorn closed 1 year ago

hwiorn commented 2 years ago

Refer #118

Previous ExternalMedia implementation uses whole ExternalMediaOptions as a request body. But asterisk only uses Variables field as the request body. So Asterisk 18(LTS) responds as 400 Bad Request which demand mandatory query parameters. This patch uses ExternalMediaOptions as query parameters except a Variables which is a JSON format.

This fix is just only for the externalMedia API. Go ARI uses similar approach in channel API(e.g. originate) like the externalMedia API that doesn't use query parameters.

This change is Reviewable

malygin commented 2 years ago

hey guys! It is unknown when the PR will be merged?