CyCoreSystems / asterisk-k8s-demo

Demo of scalable Asterisk on Kubernetes
Apache License 2.0
158 stars 72 forks source link

DTMF Support #4

Open juansalvatella opened 5 years ago

juansalvatella commented 5 years ago

Congratulations on this amazing demo! It's truly inspiring. I have been wondering on how this could be improved and thought that in case that the Google Speech Recognition does not work properly because I have a speech impediment or it's just too noisy, it would be useful to use the keyboard to state how many Asterisk replicas I want.

What would be the best approach to handle this? Maybe some logic should be pushed to Asterisk in order to determine when it should send the audio to the audiosocket or when to wait for DTMF. Looking forward to know your opinion on this.

Ulexus commented 5 years ago

The original app is still in the repo, and it uses DTMF instead of AudioSocket. You can find it here.

audiosocket is really something of a proof of concept right now. We built it for a specific purpose and customer, with an eye toward the more general need to getting streaming audio into and out of Asterisk. I am working on a Görtzel implementation in Go for another project, which is the algorithm Asterisk (and most telephony systems) uses for DTMF detection, but ultimately, I want to implement audiosocket in a channel interface or similar, which will allow us to use it fairly seamlessly with ARI, among other things (like getting DTMF detection).

juansalvatella commented 5 years ago

Amazing! If there is any way that I can contribute to that please let me know.

On Mon, 12 Nov 2018 at 19:48, Seán C. McCord notifications@github.com wrote:

The original app is still in the repo, and it uses DTMF instead of AudioSocket. You can find it here https://github.com/CyCoreSystems/asterisk-k8s-demo/tree/master/live-demo/app .

audiosocket is really something of a proof of concept right now. We built it for a specific purpose and customer, with an eye toward the more general need to getting streaming audio into and out of Asterisk. I am working on a Görtzel https://en.wikipedia.org/wiki/Goertzel_algorithm implementation in Go for another project, which is the algorithm Asterisk (and most telephony systems) uses for DTMF detection, but ultimately, I want to implement audiosocket in a channel interface or similar, which will allow us to use it fairly seamlessly with ARI, among other things (like getting DTMF detection).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CyCoreSystems/asterisk-k8s-demo/issues/4#issuecomment-437988958, or mute the thread https://github.com/notifications/unsubscribe-auth/AELLA5egQPsTY9PU6ExzfvT6vfhBgmiyks5uucJpgaJpZM4YZQPX .

Ulexus commented 5 years ago

Thanks; I'll update this issue when I have more information on either.

rainbow-cnay commented 4 years ago

I added DTMF signalling. I just started using GITHUB, please come and see it. By Google Translate. :D https://github.com/rainbow-cnay/audiosocket

Ulexus commented 4 years ago

Thanks @rainbow-cnay

Would you mind submitting it as a Pull Request?