CyCoreSystems / docker-meteor

Dockerfile and script for running Meteor on Docker
MIT License
120 stars 73 forks source link

GitHub Authentication #14

Closed zimt28 closed 7 years ago

zimt28 commented 8 years ago

Hey, it would be nice if you could tell me what I'm doing wrong here. My app's code is hosted on GitHub, so I want to pull from there.

To test how this image works I've created a fresh DO instance, ran ssh-keygen and added the public key to the repo as a deploy key. Now, when I want to run the app, I get an error:

docker run --rm \
  -e ROOT_URL=http://testsite.com \
  -e METEOR_SETTINGS='{"some": "settings"}' \
  -e REPO=https://github.com/zimt28/app \
  -e DEPLOY_KEY=/key \
  -v /root/.ssh/id_rsa.pub:/key \
  -e MONGO_URL=mongodb://url \
  ulexus/meteor
Cloning https://github.com/zimt28/app...
Cloning into '/src/app'...
fatal: could not read Username for 'https://github.com': No such device or address

And idea what's wrong with my approach? Thanks!

Ulexus commented 8 years ago

Two things that I see straight off:

zimt28 commented 8 years ago

Hi @Ulexus, thanks for your response! Authentication works, now I get this error:

Building the bundle...(this may take a while)
/usr/bin/entrypoint.sh: line 107:    45 Killed                  meteor build --directory ${APP_DIR}
Building the bundle (old version)...
This command has been deprecated in favor of 'meteor build', which allows you
to build for multiple platforms and outputs a directory instead of a single
tarball. See 'meteor help build' for more information.

And after that: https://gist.github.com/zimt28/6b60bdb597efdc3164e3

Ulexus commented 8 years ago

It looks like you've got a problem installing your npm dependencies. Are you using any interesting modules? Perhaps some local ones with odd or non-published npm dependencies?

If meteor build fails, the script attempts to fall back to the old pre-0.9 meteor bundle method. That's a red herring in your case. The problem is in the gist: the npm dependency resolution is failing.

zimt28 commented 8 years ago

@Ulexus Nothing that I'm aware of. I'm currently using meteord to dockerize my application, but building the image takes about 10 minutes, so I'm looking for an alternative. However, meteord also builds the application, but without problems.

Edit: local meteor build --architecture=os.linux.x86_64 ./build works fine, too.

avishaan commented 7 years ago

Seems I'm also having a similar issue @zimt28 how did you end up solving this?

Ulexus commented 7 years ago

@codeHatcher Could you supply a bit more information? How are you supplying the keyfile to the container? How are you referencing it with DEPLOY_KEY?

avishaan commented 7 years ago

I don't think I am seeing any auth issues. I created a new key pair added the public key to github and then linked the private key using that -v flag

via Newton Mail [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=9.0.74&pv=9.3.5&source=email_footer_2] On Thu, Sep 22, 2016 at 4:55 PM, Seán C. McCord notifications@github.com wrote: @codeHatcher [https://github.com/codeHatcher] Could you supply a bit more information? How are you supplying the keyfile to the container? How are you referencing it with DEPLOY_KEY ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [https://github.com/CyCoreSystems/docker-meteor/issues/14#issuecomment-249061589] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AFHNVg6hzcF9KWlOZRcf3oKi1NolNgN4ks5qsxV7gaJpZM4Hwd4H] .

avishaan commented 7 years ago

The reason I don't think I am having an auth issue is because I was previously having auth issues which were made clear to me via a different error which I then resolved with the -v flag

via Newton Mail [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=9.0.74&pv=9.3.5&source=email_footer_2] On Thu, Sep 22, 2016 at 4:55 PM, Seán C. McCord notifications@github.com wrote: @codeHatcher [https://github.com/codeHatcher] Could you supply a bit more information? How are you supplying the keyfile to the container? How are you referencing it with DEPLOY_KEY ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [https://github.com/CyCoreSystems/docker-meteor/issues/14#issuecomment-249061589] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AFHNVg6hzcF9KWlOZRcf3oKi1NolNgN4ks5qsxV7gaJpZM4Hwd4H] .

Ulexus commented 7 years ago

@codeHatcher I'm confused, then. Why did you say you are having the same problem?

avishaan commented 7 years ago

I'm having his most recent problem, not his auth problem. The one that says

@Ulexus Nothing that I'm aware of. I'm currently using meteord to dockerize my application, but building the image takes about 10 minutes, so I'm looking for an alternative. However, meteord also builds the application, but without problems.

Edit: local meteor build --architecture=os.linux.x86_64 ./build works fine, too.

That's why I was saying I'm having the same problem

Ulexus commented 7 years ago

Closing old issue; feel free to reopen if this is not resolved.