Update Dockerfile - Githubissues

CyCoreSystems / docker-meteor

Dockerfile and script for running Meteor on Docker

MIT License

120 stars 73 forks source link

Update Dockerfile #15

Closed logvik closed 7 years ago

logvik commented 8 years ago

We have to have ability to use "make" on step of build

Ulexus commented 8 years ago

My concern here is that build-essential is a relatively large set of packages. Docker Image sizes:

Current latest size: 270MB
With your patch: 429.4MB

That's a pretty significant image size jump to just be able to run make, which most people will not ever need, and which can almost certainly be replaced by a more generic script.

Ulexus commented 8 years ago

A note to this: because Meteor is now using a version of fibers which does not have a binary distribution, build-essential is actually necessary in order to use the preferred version. Right now, we are patching Meteor to use an older version which does have a binary distribution.

Ulexus commented 8 years ago

It looks like the new Meteor build system is going to require make anyway, so I will probably have to add this back in, after all.

Ulexus commented 7 years ago

There is bow a v1.4-build tag in the Docker Hub which includes build-essential, for those who need this.