CyCoreSystems / docker-meteor

Dockerfile and script for running Meteor on Docker
MIT License
120 stars 73 forks source link

npm install before meteor build #26

Closed athyuttamre closed 7 years ago

athyuttamre commented 7 years ago

If a Meteor app has npm dependencies listed in package.json, we need to run npm install (or perhaps npm install --production) before building the bundle.

Per this guide section:

Any npm dependencies must be installed before issuing the meteor build command to be included in the bundle.

Could you add a line to install npm dependencies before building the app?

Ulexus commented 7 years ago

Added; docker hub image updated. Let me know if this works for you. I do not use this feature.

athyuttamre commented 7 years ago

I'm not able to test anytime soon, but the commit looks good to me. If you wanted to be careful, you could do meteor npm install --production so the Node version matches the version that Meteor is using.