search

Cyan4973 / FiniteStateEntropy

New generation entropy codecs : Finite State Entropy and Huff0
BSD 2-Clause "Simplified" License
1.33k stars 143 forks source link

[programs] add support for up-to-date compilers. #114

Closed TheVice closed 7 months ago

TheVice commented 7 months ago

Hello.

If try to build code from the repository for example in recent version of Ubuntu - error will prevents to do so. It happen so because project do not support up-to-date version of C++ compilers. To deal with it - current changes proposed to merge.

There is no active GitHub Action to checking code, however I checked it in different temporary commit.

Only one different in that commit - enabled GitHub Action. Different in that Action comparing to the Travis script - there are no 'test32' and 'memtest' tests - no idea how to run it correct, because no such programs in the environment and no clue how to install last one.

Thank you.

Cyan4973 commented 7 months ago

Indeed, now that travisCI is no longer an option, moving at least some tests to github actions would be welcome.

TheVice commented 7 months ago

Sure, agree to remove type modifier. #if was provided if some C++17 an above technique planned to provided in order to manually place that variables to place with more fast access.

As for the github actions - probably addition pull request should be created - to discuss what should be in such. For example how also to cover testing on macOS and Windows environment.

Thank you.