While reading source code at the repository I detected that, checking at the FSE_readNCount function of lib/entropy_common.c file on error is not necessary - from the outside of function at least. Because same result will be returned, unless corruption of the data was detected.
Probably possibility to set brake point on that line or addition output from the error function will be the reason to left such checking.
Latter in this function at the while loop condition - placed bit operation instead of checking on logical AND.
Proposed to replaced with the last one.
Hello.
While reading source code at the repository I detected that, checking at the
FSE_readNCountfunction oflib/entropy_common.cfile on error is not necessary - from the outside of function at least. Because same result will be returned, unless corruption of the data was detected. Probably possibility to set brake point on that line or addition output from the error function will be the reason to left such checking.Latter in this function at the while loop condition - placed bit operation instead of checking on logical AND. Proposed to replaced with the last one.
Thank you.