search

CyanMobile / android_cyanmobile

5 stars 15 forks source link

remove devices from cyanogenmod #7

Closed antdking closed 12 years ago

antdking commented 12 years ago

fetching devices from cyanogenmod is a pointless exercise The device folders from there do not have the correct edits, so they will not build properly Even if they build, many cmx features won't work. Please remove the unsupported devices

Squadzone commented 12 years ago

looks good to me approve, @TaichiN can you take a look for this :)

TaichiN commented 12 years ago

I have been testing mine, exactly same as original one. https://github.com/TaichiN/android_cyanmobile/commit/ca517553fe39fae4b2ef2e203a1b74fc33840754 vendor part: https://github.com/TaichiN/android_vendor_cyanogen_cyanmobile/commit/b5b9549c8c8545939b1a77b7623b0914b0c142ce

It's more save local disk space...thought?

keyur2maru commented 12 years ago

Looks Good to me ! I Too did that Same Push Request But you Declined Mine :P @Squadzone

Squadzone commented 12 years ago

@keyur2maru , yes you did, but delete our some device too, Loool, but not problem, now this will merger :)

TaichiN commented 12 years ago

@Squadzone is there any side-effect deleting our repo from manifest?

Squadzone commented 12 years ago

just break my internal repo build xD

TaichiN commented 12 years ago

Ah,I thought using local_manifest for per device repo... nvm,I just found a solution for my "no space left on..." isuue :-)