CyanogenMod / android_device_samsung_klte-common

Samsung Galaxy S5 common device repo
25 stars 92 forks source link

[14.1][KLTE][SM-G900T] automatic rotation inconsistent #10

Open craigmjackson opened 7 years ago

craigmjackson commented 7 years ago

Rotation worked reliably on CM13. Auto sometimes responds after about a 5 second delay. If I can figure out how to build CM14, maybe I will look for how to adjust the sensor if I can find where it is configured, unless of course someone has a hint where to find this :)

craigmjackson commented 7 years ago

14.1-20161218-NIGHTLY-klte is the build number for the record.

craigmjackson commented 7 years ago

I have tried to calibrate the accelerometer, and it seems the levels are good, as tested with "Bubble Level" app. Must be some other event issue, I have yet to find a specific pattern. Sometimes it's rotating great (of course when I am trying to show someone else the problem) and sometimes I can't even get it to rotate. One method that seems to wake it up is to lock the screen and unlock, then it has to think about a new orientation, which would lead to the idea that somehow the event is not triggering reliably. I also find it interesting that there are some activities that cause brief (3-4sec) system lockups that were not present on CM13.

kn00tcn commented 7 years ago

i thought CM uses jira for bug tracking, assumed nobody looks at the github (not to mention CM shutting down)

is your gallery app rotating perfectly? everything else isnt (but i can rotate in gallery, task switch to another app to get that new rotation

snap camera seems to have a fake rotation of ui elements but not at the app level

craigmjackson commented 7 years ago

I have a hard time establishing a pattern. Sometimes I can rotate the desktop, sometimes I can't. Sometimes I can rotate a web session, sometimes I can't. The rotation feature seems to work as long as it doesn't rely on the auto-rotation. A request from an app to force horizontal or vertical seems completely reliable.

As for the build, I am still struggling with the instructions from Cyanogen, which is to be expected at this time. I see a lot of build errors that don't have a way out. I had to hack some header files but it still was no successful. I am probably going to cut my losses at this point and wait for some fresh instructions from lineage. I am not familiar enough with the Android build system to hack this together myself.

kn00tcn commented 7 years ago

they'll fix it eventually of course, it's pretty obvious (unless their browser doesnt have the problem)

rayzen6 commented 7 years ago

This issue needs to reopen here.

https://github.com/LineageOS/android_device_samsung_klte-common

schliflo commented 7 years ago

They disabled issue tracking on the new LinageOS repo's for a reason. It shouldn't be used for issue tracking in the first place. There's an official thread over at xda for reporting device specific stuff. Afaik there's no official bugtracker for general LinageOS issues yet but there will probably be one there soon ;)

craigmjackson commented 7 years ago

Good advice Florian. I will create a new thread at XDA for this device. I am not seeing much information on how to build from source, but I am still working on figuring it out. I have lots of experience building Linux OSes from source on x86 but I am totally unfamiliar with the Android build system and I think I need to throw out a lot of assumptions. If anyone knows a good pointer to a build howto I would love to start reporting/fixing issues in the source tree.

Craig Jackson craigmjackson@gmail.com 253-459-5384 cell

On Wed, Jan 4, 2017 at 1:31 AM, Florian Schlittenbauer < notifications@github.com> wrote:

They disabled issue tracking on the new LinageOS repo's for a reason. It shouldn't be used for issue tracking in the first place. There's an official thread over at xda for reporting device specific stuff. Afaik there's no official bugtracker for general LinageOS issues yet but there will probably be one there soon ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CyanogenMod/android_device_samsung_klte-common/issues/10#issuecomment-270329431, or mute the thread https://github.com/notifications/unsubscribe-auth/AIjQ9XSeCpTDm22ZKo70gR7BBphypVGNks5rO2bhgaJpZM4LRcLm .

craigmjackson commented 7 years ago

Turns out there is already an S5 thread on XDA: https://forum.xda-developers.com/galaxy-s5/unified-development/rom-cyanogenmod-14-0-galaxy-s5-android-t3476433

Craig Jackson craigmjackson@gmail.com 253-459-5384 cell

On Wed, Jan 4, 2017 at 10:16 AM, Craig Jackson craigmjackson@gmail.com wrote:

Good advice Florian. I will create a new thread at XDA for this device. I am not seeing much information on how to build from source, but I am still working on figuring it out. I have lots of experience building Linux OSes from source on x86 but I am totally unfamiliar with the Android build system and I think I need to throw out a lot of assumptions. If anyone knows a good pointer to a build howto I would love to start reporting/fixing issues in the source tree.

Craig Jackson craigmjackson@gmail.com 253-459-5384 <(253)%20459-5384> cell

On Wed, Jan 4, 2017 at 1:31 AM, Florian Schlittenbauer < notifications@github.com> wrote:

They disabled issue tracking on the new LinageOS repo's for a reason. It shouldn't be used for issue tracking in the first place. There's an official thread over at xda for reporting device specific stuff. Afaik there's no official bugtracker for general LinageOS issues yet but there will probably be one there soon ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CyanogenMod/android_device_samsung_klte-common/issues/10#issuecomment-270329431, or mute the thread https://github.com/notifications/unsubscribe-auth/AIjQ9XSeCpTDm22ZKo70gR7BBphypVGNks5rO2bhgaJpZM4LRcLm .

kn00tcn commented 7 years ago

maybe earlier i should have mentioned kevin (haggertk) is active on xda? i really assume tons of people saw the probem & the relevant people know about it

https://review.lineageos.org/#/c/101177/ notice how rotation is mentioned in the comments, not sure if it's F variant specific though

i think we're all waiting to see what's happening with lineage & when the nightlies or weeklies start, not sure one should dare build on their own yet