Cyb3r-Jak3 / html5validator-action

GitHub Action that checks HTML5 syntax.
https://github.com/marketplace/actions/html5-validator
Mozilla Public License 2.0
42 stars 12 forks source link

[BUG] the 'uses' attribute must be a path, a Docker image, or owner/repo@ref #40

Closed Sonic0 closed 1 year ago

Sonic0 commented 1 year ago

Hi @Cyb3r-Jak3, thanks for your work! I have a small problem using examples without version specifications.

Describe the bug

Error using this action without a specific version, like some examples in this repo: uses: Cyb3r-Jak3/html5validator-action

To Reproduce

Create a simple workflow like mine:

name: test
on:
  push:
    branches-ignore:
      - main
jobs:
  check-code:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: HTML5Validator
        uses: Cyb3r-Jak3/html5validator-action
        with:
          root: 'src'

What is the current bug behavior

GitHub Workflow error:

[Error: .github#L1](https://github.com/madisoft/siti-scuole-pagina-cortesia/commit/b7a35049249a1c086566835a63c0fd616cdb130d#annotation_8031992949)
the 'uses' attribute must be a path, a Docker image, or owner/repo@ref

Additional context

This is an example of a failing Workflow: https://github.com/madisoft/siti-scuole-pagina-cortesia/actions/runs/3940875123

Cyb3r-Jak3 commented 1 year ago

It should be

- name: HTML5 Validator
   uses: Cyb3r-Jak3/html5validator-action@v7.2.0

I stopped putting the version info in the README because it caused confusion when I forgot to update it. I'll add it back.

Sonic0 commented 1 year ago

@Cyb3r-Jak3 I tried the use the major version Cyb3r-Jak3/html5validator-action@v7 but it doesn't work. It would be a great solution. Changing documentation on every release would be very annoying.

Cyb3r-Jak3 commented 1 year ago

@Sonic0 The major release is something that I never got around to doing. Next time, I need to do a release, I'll include a major tag.

Sonic0 commented 1 year ago

@Cyb3r-Jak3 thanks for all