Cyb3r-Jak3 / html5validator-action

GitHub Action that checks HTML5 syntax.
https://github.com/marketplace/actions/html5-validator
Mozilla Public License 2.0
42 stars 12 forks source link

[BUG] Bug Report for CSS margin-inline Validation Issue #45

Open Alecto opened 2 days ago

Alecto commented 2 days ago

Describe the bug The HTML5Validator Action fails when encountering the margin-inline property in CSS. The validator reports that the property "doesn't exist", although it is part of modern CSS specifications.

To Reproduce Steps to reproduce the behavior:

  1. Set up the Cyb3r-Jak3/html5validator-action in a GitHub Actions workflow.
  2. Use CSS containing the margin-inline property.
  3. Run the workflow.
  4. Observe that the validator reports an error for the margin-inline property.

What is the current bug behavior

The validator does not recognize the margin-inline property and returns an error:

"file:/github/workspace/./assets/css/style.css": error: CSS: "margin-inline": Property "margin-inline" doesn't exist.

Expected behavior The margin-inline property should be recognized as valid CSS, as it is part of modern CSS specifications, and the validation should pass without errors.

Screenshots image

Additional context The GitHub Action YAML configuration used:

name: HTML CSS valid

on:
  pull_request:
  push:
    branches:
      - master

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Tests Integration with Github Actions.
        uses: Cyb3r-Jak3/html5validator-action@master
        with:
          root: ./
          css: true

The W3C Validator supports this property without issue, and margin-inline is part of the modern CSS Logical Properties.

Cyb3r-Jak3 commented 2 days ago

At first glance, this seems like something related to the upstream library not being up-to-date. Could you try my experimental action using:

name: HTML CSS valid

on:
  pull_request:
  push:
    branches:
      - master

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Tests Integration with Github Actions.
        uses: Cyb3r-Jak3/html5validator-action-experimental@master
        with:
          root: ./
          css: true

This one uses my fork of html5validator which has a more update to jar file

Alecto commented 2 days ago

Hi there,

I've applied the changes you suggested, and I'm pleased to share that the validation passed successfully! Please find attached the screenshots showing the successful run.

Thank you very much for your help and guidance. If there's anything else you need, feel free to ask.

Best regards,
Andrii

image image