search

CybOXProject / python-cybox

A Python library for parsing, manipulating, and generating CybOX content.
http://cybox.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
77 stars 42 forks source link

Fix handling of empty Hash values #321

Closed chisholm closed 5 years ago

chisholm commented 5 years ago

Fix the postset_hook for Hash so it allows empty hashes without crashing.

Related: #320.

clenk commented 5 years ago

Feel free to remove the py26 environment. Something like this line might fix the py34 environment: https://github.com/oasis-open/cti-stix-elevator/pull/163/files#diff-b91f3d5bd63fcd17221b267e851608e8R12

chisholm commented 5 years ago

The problem with using tox tricks is that that isn't how people will be installing the library for real use. The library's declared requirements need to be accurate, or they'll have a broken installation. Those tricks seem more appropriate for testing different valid combinations of libraries. Correct me if I'm wrong, but the commit you referenced will ensure the tox tests pass, but if someone just 'pip installs' the library, it won't look at the tox config so they'll get the wrong version of lxml and a broken installation. One hopes that tox config change was paired with an update to setup.py or related.

clenk commented 5 years ago

True, good point; the lxml version limit should go in setup.py.

chisholm commented 5 years ago

One more small question: should py33 be in the tox envlist? It's not included in travis tests.

clenk commented 5 years ago

No, we don't need to support 3.3 any more. Looks like it wasn't fully removed. The list of Python versions in classifiers in setup.py also needs updating.

chisholm commented 5 years ago

Done.