search

Cyber-Duck / laravel-excel

This package provides a way to export an Eloquent collection as an excel file and to import a Excel file as an Eloquent collection.
https://www.cyber-duck.co.uk
MIT License
74 stars 27 forks source link

Remove misleading passage #5

Closed Konafets closed 6 years ago

Konafets commented 6 years ago

The importer class is neither fluent nor it is possible to load the file as described because getCollection does not take any parameters.

Konafets commented 6 years ago

Alternative, if the project not dead yet, I would provide a PR which makes the importer class fluent and adding a parameter to getCollection().

clemblanco commented 6 years ago

Please do! 👍

On 1 December 2017 at 12:05:13, Stefano Kowalke (notifications@github.com) wrote:

Alternative, if the project not dead yet, I would provide a PR which makes the importer class fluent and adding a parameter to getCollection().

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cyber-Duck/laravel-excel/pull/5#issuecomment-348478476, or mute the thread https://github.com/notifications/unsubscribe-auth/AAozA8OqAXQEqi7B4E_OXmToEQneJpIoks5s7-t5gaJpZM4QyQTt .

rap2hpoutre commented 6 years ago

Alternative, if the project not dead yet, I would provide a PR which makes the importer class fluent and adding a parameter to getCollection().

Woops, I did not see this package, so I created one too: https://github.com/rap2hpoutre/fast-excel

:/

Sorry for the duplicate (BTW, fast excel is "fluent")