Update raw.githubusercontent.com

CyberAgentAILab / cmaes

Python library for CMA Evolution Strategy.

https://arxiv.org/abs/2402.01373

MIT License

359 stars 62 forks source link

Update raw.githubusercontent.com #180

Closed nomuramasahir0 closed 3 months ago

nomuramasahir0 commented 3 months ago

I observed the figure of CMA with Margin was not working before the authentication of CyberAgent organization. Anyway one easy idea to fix is to include the figure itself, rather than link.

c-bata commented 3 months ago

I can see the figure on the Google Chrome's secret window :eyes:

nomuramasahir0 commented 3 months ago

Yes, now I also can see it, but before the authentication(?) of CA (conducted at the time of this issue created), I was not able to see the figure. I confirmed this behavior in a different browser. I'm not sure why it was happened, but anyway I think hosting the figure in this repository is safe. I have received consent from @ha-mano (owner of https://github.com/EvoConJP/CMA-ES_with_Margin), so the figure will be added to this repository.

c-bata commented 3 months ago

Adding the figure in this repository make pip install git+https://github.com/CyberAgentAILab/cmaes.git slower. So I recommend a workaround where you upload the file to the issue and use the link to the uploaded image, as shown below:

https://github.com/CyberAgentAILab/cmaes/issues/1

nomuramasahir0 commented 3 months ago

Oh, you're right! Thank you for the advice.

@ha-mano Please follow the above comment by @c-bata .

ha-mano commented 3 months ago

Thank you for your guidance and support in resolving this issue! The issue has been addressed as discussed. Please refer to pull request #181 for more details.

nomuramasahir0 commented 3 months ago

Thanks! It looks great.