search

CyberBoardPBEM / cbwindows

CyberBoard Play by EMail system for Windows
MIT License
7 stars 4 forks source link

Why is CGamDoc's CRollState not serialized? #89

Closed wsu-cb closed 1 year ago

wsu-cb commented 2 years ago

CGamDoc has a CRollState* member, but it is explicitly commented as not being serialized. It would be nice if it were serialized so that players of games like Space Empires and Empire of the Sun that always use 10-sided dice could avoid having to repeatedly set the dice face value.

So the question is why is CGamDoc's CRollState* not serialized?

DLLarson commented 2 years ago

So the question is why is CGamDoc's CRollState* not serialized?

Frankly I don't know why.

If the player used a user supplied seed (such as the price of a stock on some day) the seed and its current propagated value should certainly be saved or the sequence won't be exactly reproducible if a player leaves the game and comes back to finish the move.

The comment suggests that I may have wanted to do it but had some doubt at that time. Or perhaps the information was stored somewhere else (I don't see it though.)

-Dale

wsu-cb commented 2 years ago

Frankly I don't know why.

If the player used a user supplied seed (such as the price of a stock on some day) the seed and its current propagated value should certainly be saved or the sequence won't be exactly reproducible if a player leaves the game and comes back to finish the move.

The comment suggests that I may have wanted to do it but had some doubt at that time. Or perhaps the information was stored somewhere else (I don't see it though.)

-Dale

I have been working on a .gbx for d10-based Space Empires, and I have already changed the file format version, so I will experiment with saving the CGamDoc CRollState* and see if there is any obvious problem.

DLLarson commented 2 years ago

I have been working on a .gbx for d10-based Space Empires, and I have already changed the file format version, so I will experiment with saving the CGamDoc CRollState* and see if there is any obvious problem.

I think that's a good idea.

wsu-cb commented 1 year ago

It looks like this didn't close automatically.